Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to PUT to Story #4

Merged
merged 5 commits into from Jul 5, 2016
Merged

Conversation

steveklebanoff
Copy link
Contributor

Adds the ability to do a PUT on a Story.

json_request(method, url, body, authorization_header(auth, @user_agent))
json_request(
method, url, body,
["Content-Type": "application/json"] ++ authorization_header(auth, @user_agent)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pivotal wouldn't recognize the PUT request's data unless Content-Type was set. Open to any better ways of doing this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now. I'll think on it and refactor later if the need arises.

@coveralls
Copy link

coveralls commented Jul 1, 2016

Coverage Status

Coverage increased (+2.3%) to 75.758% when pulling e7c91ca on steveklebanoff:stories-put into 0122749 on dashofcode:master.

@coveralls
Copy link

coveralls commented Jul 1, 2016

Coverage Status

Coverage increased (+2.3%) to 75.758% when pulling 08f9533 on steveklebanoff:stories-put into 0122749 on dashofcode:master.

@forest
Copy link
Member

forest commented Jul 5, 2016

Thanks for the contribution.

@forest forest merged commit db7a937 into dashofcode:master Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants