Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retain gift card response in release builds #1095

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix: retain gift card response in release builds #1095

merged 1 commit into from
Mar 8, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Mar 7, 2023

Proguard removes the data field from PurchaseGiftCardResponse class.

Issue being fixed or feature implemented

  • Assign default Data instance to the data field.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Mar 7, 2023
HashEngineering
HashEngineering approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit ac05441 into feature-dashdirect Mar 8, 2023
@Syn-McJ Syn-McJ deleted the fix-giftcard-proguard branch March 8, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HashEngineering HashEngineering HashEngineering approved these changes

@hadia hadia Awaiting requested review from hadia

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Syn-McJ @HashEngineering