Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dashdirect UI issues #1100

Merged
merged 103 commits into from
Mar 21, 2023

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 20, 2023

Issue being fixed or feature implemented

  • Continue button on the auth screen should display loading indicator
  • PIN field should have a numeric keyboard and not display email suggestions
  • Enabled/disabled state on the Next button doesn’t match min-max values if those were updated.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

hadia and others added 30 commits February 20, 2023 23:10
hadia and others added 19 commits March 13, 2023 20:30
# Conflicts:
#	features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/dashdirect/DashDirectUserAuthFragment.kt
#	features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/dashdirect/DashDirectViewModel.kt
#	features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/dashdirect/PurchaseGiftCardFragment.kt
#	features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/dashdirect/dialogs/GiftCardDetailsDialog.kt
#	features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/dashdirect/dialogs/GiftCardDetailsViewModel.kt
#	features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/dashdirect/dialogs/PurchaseGiftCardConfirmDialog.kt
#	features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/explore/SearchFragment.kt
#	features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/explore/dialogs/ExploreDashInfoDialog.kt
#	wallet/src/de/schildbach/wallet/ui/main/MainViewModel.kt
#	wallet/src/de/schildbach/wallet/ui/main/WalletTransactionsFragment.kt
@hadia hadia marked this pull request as ready for review March 20, 2023 13:33
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@HashEngineering HashEngineering merged commit f347b47 into feature-dashdirect Mar 21, 2023
@Syn-McJ Syn-McJ deleted the feature_dashdirect_UI_issues branch March 23, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants