Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashdirect): restore tests #1105

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix(dashdirect): restore tests #1105

merged 3 commits into from
Mar 31, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Mar 30, 2023

Some Explore tests are broken in dashdirect branch after migrating to DataStore.

Issue being fixed or feature implemented

  • Made BaseConfig methods open for mocking
  • Replaced runBlocking with runTest since calling one runBlocking inside another causes a deadlock.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Mar 30, 2023
@Syn-McJ Syn-McJ mentioned this pull request Mar 30, 2023
Merged
3 tasks
HashEngineering
HashEngineering approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@Syn-McJ Syn-McJ merged commit 292ecb9 into feature-dashdirect Mar 31, 2023
@Syn-McJ Syn-McJ deleted the fix-restore-tests branch March 31, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HashEngineering HashEngineering HashEngineering approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Syn-McJ @HashEngineering