Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashdirect): retries in case of error #1131

Merged
merged 6 commits into from
Jun 17, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jun 8, 2023

Given some timing issues DashDirect API has, we want to retry in the case PaymentStatus request returns an error. Subsequent requests might return a different result.

Issue being fixed or feature implemented

  • Initial delay increased to 1s
  • Ticker delay increased to 1.5s
  • Retry counter added for 3 retries in the case of an error

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Jun 8, 2023
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@Syn-McJ Syn-McJ merged commit 0ceedf0 into feature-dashdirect Jun 17, 2023
3 checks passed
@Syn-McJ Syn-McJ deleted the feature-dashdirect-delay branch June 17, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants