Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coinbase): pull to refresh #1167

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jul 23, 2023

We want to add a "pull to refresh" functionality to Coinbase.

Issue being fixed or feature implemented

  • Add Pull To Refresh to Coinbase and other integrations (Uphold, CrowdNode).
  • Migrate Coinbase prefs to datastore config.
  • Refactor exchange rates in Coinbase to avoid crashes if rates are missing.
  • Apply ktlint here and there.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Jul 23, 2023
@@ -14,385 +14,389 @@
~ You should have received a copy of the GNU General Public License
~ along with this program. If not, see <http://www.gnu.org/licenses/>.
-->
<androidx.constraintlayout.widget.ConstraintLayout
<androidx.swiperefreshlayout.widget.SwipeRefreshLayout
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file wasn't actually changed as much as the diff seems to suggest - the entire layout was simply wrapped into SwipeRefreshLayout.

@HashEngineering HashEngineering merged commit 0a7076a into master Jul 27, 2023
2 checks passed
@Syn-McJ Syn-McJ deleted the feature-coinbase-pull-refresh branch July 28, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants