-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature android 13 #1193
Merged
Merged
Feature android 13 #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
force-pushed
the
feature-android-13
branch
from
August 29, 2023 22:42
a71c816
to
f174b95
Compare
HashEngineering
commented
Aug 31, 2023
@@ -118,7 +117,7 @@ dependencies { | |||
testImplementation "org.jetbrains.kotlinx:kotlinx-coroutines-test:$coroutinesVersion" | |||
testImplementation "org.mockito.kotlin:mockito-kotlin:$mockitoVersion" | |||
testImplementation "androidx.arch.core:core-testing:$coreTestingVersion" | |||
testImplementation "org.robolectric:robolectric:4.8.1" | |||
testImplementation "org.robolectric:robolectric:4.9.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4.8.x doesn't support SDK 33 (Android 13). One test will fail.
Syn-McJ
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Target Android 13 and ask user to approve of notifications
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: