Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature android 13 #1193

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Feature android 13 #1193

merged 5 commits into from
Sep 1, 2023

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Aug 25, 2023

Issue being fixed or feature implemented

Target Android 13 and ask user to approve of notifications

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering self-assigned this Aug 25, 2023
@HashEngineering HashEngineering marked this pull request as ready for review August 31, 2023 23:04
@@ -118,7 +117,7 @@ dependencies {
testImplementation "org.jetbrains.kotlinx:kotlinx-coroutines-test:$coroutinesVersion"
testImplementation "org.mockito.kotlin:mockito-kotlin:$mockitoVersion"
testImplementation "androidx.arch.core:core-testing:$coreTestingVersion"
testImplementation "org.robolectric:robolectric:4.8.1"
testImplementation "org.robolectric:robolectric:4.9.2"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4.8.x doesn't support SDK 33 (Android 13). One test will fail.

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering merged commit 32d50f3 into master Sep 1, 2023
2 checks passed
@Syn-McJ Syn-McJ deleted the feature-android-13 branch September 2, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants