Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(coinbase): transition to v3 Buy API #1212

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 2, 2023

Coinbase v2 Buy APIs are being shutdown, so we need to switch to v3.

Issue being fixed or feature implemented

  • Move the Coinbase feature out of the separate activity into the nav_home graph.
  • Rename packages to align with other integrations.
  • Replace v2/accounts with api/v3/brokerage/accounts calls.
  • Replace v2/accounts/{account_id}/buys with api/v3/brokerage/orders calls.
  • Rearrange Buy flow: no need to create and commit an order as the /orders endpoint executes the order immediately.
  • Other refactoring to improve some unneeded/convoluted code.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Oct 2, 2023
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@HashEngineering HashEngineering merged commit 421c2da into master Oct 3, 2023
2 checks passed
@HashEngineering HashEngineering deleted the chore-coinbase-buy branch October 30, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants