Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update crowdnode text for per block withdrawal limits #1231

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

Change some text to match iOS and latest designs.

Related PR's and Dependencies

https://github.com/dashpay/dashwallet-ios/pull/628/files#diff-598223494c00a23f8cee97c4e2cbd7073a5cbb3fbc5ceb94cdcb661e7978a375R309

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@@ -144,7 +144,7 @@
<string name="crowdnode_withdraw_without_limits_online">Withdraw without limits with an online account on CrowdNode website.</string>
<string name="crowdnode_withdrawal_limits_error">This error is most likely due to exceeding CrowdNode withdrawal limits. Try again later.</string>
<string name="crowdnode_withdrawal_limits_per_block_title">Please wait before initiating the next withdrawal</string>
<string name="crowdnode_withdrawal_limits_per_block_message">Please wait 5 minutes before initiating another withdrawal.</string>
<string name="crowdnode_withdrawal_limits_per_block_message">You need to wait 5 minutes before initiating another withdrawal</string>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should match #1231 as it was copied and pasted into this PR on the one text item.

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering merged commit ad8c81b into master Dec 1, 2023
2 checks passed
@HashEngineering HashEngineering deleted the bugfix-crowdnode-text branch January 5, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants