fix: eliminate race condition when updating BlockchainState #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts in "Syncing..." for a long time
Syn-McJ
approved these changes
Dec 16, 2023
HashEngineering
commented
Dec 17, 2023
Comment on lines
-176
to
+173
| mnlist.validMNsCount | ||
| var virtualMNCount = 0 | ||
| mnlist.forEachMN(true) { entry -> | ||
| virtualMNCount += if (entry.isHPMN) 4 else 1 | ||
| } | ||
| virtualMNCount |
There was a problem hiding this comment.
EvoNodes have 4x the collateral (4000 instead of 1000) and receive 4x times the block rewards, so we will count them as 4 regular masternodes.
Each block only pays out a single masternode or 1/4 of a EvoNode. EvoNodes receive 4 blocks of rewards in a row. APY calculations are based on a single block.
Without this fix, we are using the number of actual masternode servers which will inflate the APY by around 10%.
Future improvements:
- We could base the APY on a number of blocks in recent history such as the past 100.
- Masternode reward calculations could be moved into dashj, but not sure which class would get the functions (Block or Masternode List)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
Resolve the issue where "Syncing..." appears for a long time:
How Has This Been Tested?
Checklist: