Skip to content

Commit

Permalink
Fix banning when local node doesn't have the vvec (#2739)
Browse files Browse the repository at this point in the history
When ProcessMessageBatchedSigShares returns false, it's interpreted as
if an invalid/malicious message was received, causing a ban. So, we should
return "!ban" instead of just "ban".
  • Loading branch information
codablock authored and UdjinM6 committed Mar 5, 2019
1 parent 4a495c6 commit a34fb6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/llmq/quorums_signing_shares.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ bool CSigSharesManager::ProcessMessageBatchedSigShares(CNode* pfrom, const CBatc

bool ban = false;
if (!PreVerifyBatchedSigShares(pfrom->id, sessionInfo, batchedSigShares, ban)) {
return ban;
return !ban;
}

std::vector<CSigShare> sigShares;
Expand Down

0 comments on commit a34fb6d

Please sign in to comment.