Relay spork after updating internal spork maps (#2777)

Otherwise regtest nodes might end up sending "getdata" too fast, which results in the spork not being propagated.
dashpay · Mar 18, 2019 · a5d2edb · a5d2edb
1 parent e52763d
commit a5d2edb
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/spork.cpp b/src/spork.cpp
@@ -235,10 +235,12 @@ bool CSporkManager::UpdateSpork(int nSporkID, int64_t nValue, CConnman& connman)
             LogPrintf("CSporkManager::UpdateSpork: failed to find keyid for private key\n");
             return false;
         }
+        {
+            LOCK(cs);
+            mapSporksByHash[spork.GetHash()] = spork;
+            mapSporksActive[nSporkID][keyIDSigner] = spork;
+        }
         spork.Relay(connman);
-        LOCK(cs);
-        mapSporksByHash[spork.GetHash()] = spork;
-        mapSporksActive[nSporkID][keyIDSigner] = spork;
         return true;
     }