Skip to content

Commit

Permalink
Don't pass CEvoDB to CDKGSessionHandler and CDKGSession
Browse files Browse the repository at this point in the history
Was never used.
  • Loading branch information
codablock committed Mar 8, 2019
1 parent 64ae912 commit acb52f6
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
6 changes: 2 additions & 4 deletions src/llmq/quorums_dkgsession.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "bls/bls_worker.h"

#include "evo/deterministicmns.h"
#include "evo/evodb.h"

#include "llmq/quorums_utils.h"

Expand Down Expand Up @@ -246,7 +245,6 @@ class CDKGSession
private:
const Consensus::LLMQParams& params;

CEvoDB& evoDb;
CBLSWorker& blsWorker;
CBLSWorkerCache cache;
CDKGSessionManager& dkgManager;
Expand Down Expand Up @@ -287,8 +285,8 @@ class CDKGSession
std::set<uint256> validCommitments;

public:
CDKGSession(const Consensus::LLMQParams& _params, CEvoDB& _evoDb, CBLSWorker& _blsWorker, CDKGSessionManager& _dkgManager) :
params(_params), evoDb(_evoDb), blsWorker(_blsWorker), cache(_blsWorker), dkgManager(_dkgManager) {}
CDKGSession(const Consensus::LLMQParams& _params, CBLSWorker& _blsWorker, CDKGSessionManager& _dkgManager) :
params(_params), blsWorker(_blsWorker), cache(_blsWorker), dkgManager(_dkgManager) {}

bool Init(int _height, const uint256& _quorumHash, const std::vector<CDeterministicMNCPtr>& mns, const uint256& _myProTxHash);

Expand Down
7 changes: 3 additions & 4 deletions src/llmq/quorums_dkgsessionhandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,12 @@ void CDKGPendingMessages::Clear()

//////

CDKGSessionHandler::CDKGSessionHandler(const Consensus::LLMQParams& _params, CEvoDB& _evoDb, ctpl::thread_pool& _messageHandlerPool, CBLSWorker& _blsWorker, CDKGSessionManager& _dkgManager) :
CDKGSessionHandler::CDKGSessionHandler(const Consensus::LLMQParams& _params, ctpl::thread_pool& _messageHandlerPool, CBLSWorker& _blsWorker, CDKGSessionManager& _dkgManager) :
params(_params),
evoDb(_evoDb),
messageHandlerPool(_messageHandlerPool),
blsWorker(_blsWorker),
dkgManager(_dkgManager),
curSession(std::make_shared<CDKGSession>(_params, _evoDb, _blsWorker, _dkgManager)),
curSession(std::make_shared<CDKGSession>(_params, _blsWorker, _dkgManager)),
pendingContributions((size_t)_params.size * 2), // we allow size*2 messages as we need to make sure we see bad behavior (double messages)
pendingComplaints((size_t)_params.size * 2),
pendingJustifications((size_t)_params.size * 2),
Expand Down Expand Up @@ -146,7 +145,7 @@ bool CDKGSessionHandler::InitNewQuorum(int newQuorumHeight, const uint256& newQu

const auto& consensus = Params().GetConsensus();

curSession = std::make_shared<CDKGSession>(params, evoDb, blsWorker, dkgManager);
curSession = std::make_shared<CDKGSession>(params, blsWorker, dkgManager);

if (!deterministicMNManager->IsDIP3Enforced(newQuorumHeight)) {
return false;
Expand Down
3 changes: 1 addition & 2 deletions src/llmq/quorums_dkgsessionhandler.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ class CDKGSessionHandler
std::atomic<bool> stopRequested{false};

const Consensus::LLMQParams& params;
CEvoDB& evoDb;
ctpl::thread_pool& messageHandlerPool;
CBLSWorker& blsWorker;
CDKGSessionManager& dkgManager;
Expand All @@ -119,7 +118,7 @@ class CDKGSessionHandler
CDKGPendingMessages pendingPrematureCommitments;

public:
CDKGSessionHandler(const Consensus::LLMQParams& _params, CEvoDB& _evoDb, ctpl::thread_pool& _messageHandlerPool, CBLSWorker& blsWorker, CDKGSessionManager& _dkgManager);
CDKGSessionHandler(const Consensus::LLMQParams& _params, ctpl::thread_pool& _messageHandlerPool, CBLSWorker& blsWorker, CDKGSessionManager& _dkgManager);
~CDKGSessionHandler();

void UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload);
Expand Down
2 changes: 1 addition & 1 deletion src/llmq/quorums_dkgsessionmgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void CDKGSessionManager::StartMessageHandlerPool()
for (const auto& qt : Params().GetConsensus().llmqs) {
dkgSessionHandlers.emplace(std::piecewise_construct,
std::forward_as_tuple(qt.first),
std::forward_as_tuple(qt.second, evoDb, messageHandlerPool, blsWorker, *this));
std::forward_as_tuple(qt.second, messageHandlerPool, blsWorker, *this));
}

messageHandlerPool.resize(2);
Expand Down

0 comments on commit acb52f6

Please sign in to comment.