Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstantX should have "getixstatus {txid}" command #660

Closed
eduffield222 opened this issue Dec 18, 2015 · 4 comments
Closed

InstantX should have "getixstatus {txid}" command #660

eduffield222 opened this issue Dec 18, 2015 · 4 comments
Assignees

Comments

@eduffield222
Copy link

After InstantX confirms on the network, it's hard to tell if it succeeded via the API. Currently the best way is to use gettransaction {txid}, then grab the "confirmations" which also includes IX confirmations .

https://github.com/dashpay/dash/blob/master/src/rpcwallet.cpp#L1597

I propose adding a separate command, which would tell you if a transaction was safe.
getixstatus {txid} -> returns "locked", "unknown", "unconfirmed" or "failure"

Also, adding the "ixstatus" field to gettransaction, which would make understanding the output a lot easier.

Merchants running the full daemon could then easily utilize IX when receiving funds.

@eduffield222 eduffield222 self-assigned this Dec 18, 2015
@eduffield222 eduffield222 added this to the 12.1 milestone Dec 18, 2015
@UdjinM6 UdjinM6 modified the milestones: 12.1, 12.3 Jan 2, 2018
@PastaPastaPasta
Copy link
Member

Fixed by: #1628, should be closed @UdjinM6 @nmarley

@UdjinM6
Copy link

UdjinM6 commented Sep 17, 2018

Well, we never implemented anything like getixstatus but yes, all wallet tx-related RPCs should have instantlock (bool) field to indicate the IS status now. So the issue is half-fixed but I'm not sure if we need smth like getixstatus at all, probably not.

@PastaPastaPasta
Copy link
Member

Probably not, I don't think so.

@UdjinM6
Copy link

UdjinM6 commented Jan 27, 2019

All related rpc commands have instantlock field now which indicates whether tx was successfully locked or not. Closing.

@UdjinM6 UdjinM6 closed this as completed Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants