Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in addExtraPayloadToTx #43

Merged
merged 1 commit into from
Dec 31, 2018
Merged

fix typo in addExtraPayloadToTx #43

merged 1 commit into from
Dec 31, 2018

Conversation

Cofresi
Copy link

@Cofresi Cofresi commented Dec 31, 2018

fixes typo in addExtraPayloadToTx

@Cofresi Cofresi changed the title fix typoin addExtraPayloadToTx fix typo in addExtraPayloadToTx Dec 31, 2018
@Cofresi Cofresi requested a review from nmarley December 31, 2018 00:48
nmarley
nmarley approved these changes Dec 31, 2018
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

(Now I'm assuming this was indeed a typo which got copied to the insight-api repo as well.)

@Cofresi
Copy link
Author

Cofresi commented Dec 31, 2018 •
edited
Loading

(Now I'm assuming this was indeed a typo which got copied to the insight-api repo as well.)

Yes, you were completely right. Good catch! I only tested cbTx and proUpRevTx and completely missed this.
https://github.com/dashpay/dash/blob/develop/src/rpc/rawtransaction.cpp#L140

@Cofresi Cofresi merged commit b9f5de9 into develop Dec 31, 2018
@nmarley nmarley deleted the fix-typo branch January 2, 2019 11:53
Cofresi added a commit that referenced this pull request Jan 10, 2019
@Cofresi
Release v5.0.0 (#41)
62da616 
* V. 4.0.0 (#24)

* Bump bitcore-lib to 0.15.3

* Feat : Added governance methods (deserialize, budget, votes, count,..)

* Impr : Removed autoinstaller

* Remove : Useless npm dependency

* Impr : Use uninstall method instead of npm

* Chore : bitcoind-rpc to dashd-rpc

* Chore : bitcore-lib => dashcore-lib

* Chore : bitcore-p2p => dashcore-p2p

* Impr : Dashified + Doc

* Fix : typo

* Impr : More Dashifying

* Impr : Even more dashifying

* Fix : Old bug

* Fix : Bug in logger test file

* Fix : Modify regtest for new path

* Impr : connect instead of spawn

* typo: s/need/needs/

* Updated docs and deps

* Update test for default conf integration

* Update deps

* Revert logger test cases

* linting impr

* Update npm lockfile

* Added log case for <node6

* Update travis file (#42)

* Doc : Dev Environment (#43)

* Bump to 4.0.0

* Small fixes

* updating readme and package.json

* package-lock.json

* [EV-1174] bump version to 5.0.0

* [EV-1174] correct readme instructions

* [EV-1174] update dashcore-lib to 1.0.0-alpha.23

* [EV-1174] package-lock.json

* [EV-1174] update dependencies

* bump dashcore-lib version

* bump dashcore-p2p version

* update package-lock.json

* bump dashcore-lib dep to 0.16.1

* update package-lock.json
Cofresi pushed a commit that referenced this pull request Jan 21, 2019
@Alex-Werner
V. 4.0.0 (#24)
d2ffd2a 
* Bump bitcore-lib to 0.15.3

* Feat : Added governance methods (deserialize, budget, votes, count,..)

* Impr : Removed autoinstaller

* Remove : Useless npm dependency

* Impr : Use uninstall method instead of npm

* Chore : bitcoind-rpc to dashd-rpc

* Chore : bitcore-lib => dashcore-lib

* Chore : bitcore-p2p => dashcore-p2p

* Impr : Dashified + Doc

* Fix : typo

* Impr : More Dashifying

* Impr : Even more dashifying

* Fix : Old bug

* Fix : Bug in logger test file

* Fix : Modify regtest for new path

* Impr : connect instead of spawn

* typo: s/need/needs/

* Updated docs and deps

* Update test for default conf integration

* Update deps

* Revert logger test cases

* linting impr

* Update npm lockfile

* Added log case for <node6

* Update travis file (#42)

* Doc : Dev Environment (#43)

* Bump to 4.0.0

* Small fixes
Cofresi added a commit that referenced this pull request Jan 21, 2019
@Cofresi
Release 5.0.0 (#48)
02fc49e 
* Bump bitcore-lib to 0.15.3

* Feat : Added governance methods (deserialize, budget, votes, count,..)

* Impr : Removed autoinstaller

* Remove : Useless npm dependency

* Impr : Use uninstall method instead of npm

* Chore : bitcoind-rpc to dashd-rpc

* Chore : bitcore-lib => dashcore-lib

* Chore : bitcore-p2p => dashcore-p2p

* Impr : Dashified + Doc

* Fix : typo

* Impr : More Dashifying

* Impr : Even more dashifying

* Fix : Old bug

* Fix : Bug in logger test file

* Fix : Modify regtest for new path

* Impr : connect instead of spawn

* typo: s/need/needs/

* Updated docs and deps

* Update test for default conf integration

* Update deps

* Revert logger test cases

* linting impr

* Update npm lockfile

* Added log case for <node6

* Update travis file (#42)

* Doc : Dev Environment (#43)

* Bump to 4.0.0

* Small fixes

* minor fix in README

* update dashd service docs

The service is currently changed to `dashd`, but the docs were not updated, so
now these are incorrect. Also, we are not supporting 'spawn' any longer, only
direct connections.

* support no earlier than 12.2

* we do not support Node.js < 6

* add DCG to LICENSE info

* use dashcore v12.3+

* 0.13 release: update dependencies to latest dashcore-lib, dashd-rpc (#38)

for special transaction parsing

* [EV-1171][EV-1195] Update dependency of dashcore-lib to new prerelease 1.0.0-alpha.22 (#39)

* 0.13 release: update dependencies to latest dashcore-lib 1.0.0-alpha.22

* 0.13 release: update package-lock.json

* Pass through DIP2 extra payloads in getDetailedTransaction (#42)

* Pass through DIP2 extra payloads in getDetailedTransaction

* fix jshint warning

* fix typo (#43)

* Release v5.0.0 (#41)

* V. 4.0.0 (#24)

* Bump bitcore-lib to 0.15.3

* Feat : Added governance methods (deserialize, budget, votes, count,..)

* Impr : Removed autoinstaller

* Remove : Useless npm dependency

* Impr : Use uninstall method instead of npm

* Chore : bitcoind-rpc to dashd-rpc

* Chore : bitcore-lib => dashcore-lib

* Chore : bitcore-p2p => dashcore-p2p

* Impr : Dashified + Doc

* Fix : typo

* Impr : More Dashifying

* Impr : Even more dashifying

* Fix : Old bug

* Fix : Bug in logger test file

* Fix : Modify regtest for new path

* Impr : connect instead of spawn

* typo: s/need/needs/

* Updated docs and deps

* Update test for default conf integration

* Update deps

* Revert logger test cases

* linting impr

* Update npm lockfile

* Added log case for <node6

* Update travis file (#42)

* Doc : Dev Environment (#43)

* Bump to 4.0.0

* Small fixes

* updating readme and package.json

* package-lock.json

* [EV-1174] bump version to 5.0.0

* [EV-1174] correct readme instructions

* [EV-1174] update dashcore-lib to 1.0.0-alpha.23

* [EV-1174] package-lock.json

* [EV-1174] update dependencies

* bump dashcore-lib version

* bump dashcore-p2p version

* update package-lock.json

* bump dashcore-lib dep to 0.16.1

* update package-lock.json

* Update inactive zmq lib to active zeromq (#46)

* update incactive zmq dep to active zeromq lib

* fix tests

* update package-lock.json

* temp disable _initZmqSubSocket test

* revert tests and fix stubbed zeromq reference

* Update deps with dashcore-lib 0.16.5 (#44)

* update dashcore-lib to 0.16.3

* update package-lock.json

* upgrade dashcore-lib dependency

* update dashcore-lib to 0.16.5

* Updated package.json and package-lock.json

* update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarley nmarley nmarley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cofresi @nmarley