DH 7: ref: nix async lib in the simplest way #61
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on other PRs now, so the relevant commit is just 7fea699.
This replaces
async
withPromise
in the simplest way possible.Much of the time task pools are used with such a high number that they actually cause thrashing and decrease performance.
My assumption that the magic number of 16 tasks probably wasn't tested, but just chosen at random and this would actually be more performant queuing single tasks in a row anyway.
Since it's being called on a batch (which already contains some number of requests), I think that even more.
Built on #60 just look at b94b291 for actual code changes.
Essentially: