Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashpay): mock add contact #586

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Aug 10, 2023

Issue being fixed or feature implemented

While the Add Contact flow is restored, we want the ability to mock the added contact in the list of contacts.

What was done?

  • Put the fake added contact into core data.
  • Restore hourglass icons to fix the crash in DWHourGlassAnimationView.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from tikhop August 10, 2023 08:30
@Syn-McJ Syn-McJ self-assigned this Aug 10, 2023
username.blockchainIdentity = entity;
entity.dashpayUsername = username;
contact.associatedBlockchainIdentity = entity;
NSError *error = [contact applyTransientDashpayUser:identity.transientDashpayUser save:YES];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit clumsy but does the job - the fake contact is written down and appears in the contact list.

Copy link
Collaborator

@tikhop tikhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Syn-McJ Syn-McJ merged commit c61af34 into dashpay:feature/dashpay Aug 11, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the feature/dashpay-add-contact branch August 21, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants