Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashpay): restore invitations (send/receive) #594

Merged
merged 5 commits into from
Aug 29, 2023
Merged

feat(dashpay): restore invitations (send/receive) #594

merged 5 commits into from
Aug 29, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Aug 25, 2023

Issue being fixed or feature implemented

The first part of restoring invitations in DashPay - send flow.

What was done?

  • Restored Send flow
  • Changed the way BlockchainIdentity.registerOnNetwork is called to pass the prompt message.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from tikhop August 25, 2023 13:50
@Syn-McJ Syn-McJ self-assigned this Aug 25, 2023
@Syn-McJ Syn-McJ changed the title feat(dashpay): restore invitations (send) feat(dashpay): restore invitations (send/receive) Aug 27, 2023
tikhop
tikhop approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@tikhop tikhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Syn-McJ Syn-McJ merged commit 3177d7b into dashpay:feature/dashpay Aug 29, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the feature/dashpay-invitations branch August 29, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tikhop tikhop tikhop approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Syn-McJ @tikhop