Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashpay): redesing Home screen #604

Merged
merged 4 commits into from
Sep 19, 2023
Merged

feat(dashpay): redesing Home screen #604

merged 4 commits into from
Sep 19, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Sep 19, 2023

Issue being fixed or feature implemented

On the DashPay home screen, we want the userpic and notification indicator to be smaller and moved to the app bar.

What was done?

  • Remove DashPayProfileView as not needed anymore.
  • Add leftBarButtonItem and rightBarButtonItem to the DWHomeViewController.
  • Track DashPay profile updates to reflect in the appbar.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ self-assigned this Sep 19, 2023
pankcuf
pankcuf approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Syn-McJ Syn-McJ merged commit 2ce3f4a into dashpay:feature/dashpay Sep 19, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the feature/dashpay-home-screen branch September 19, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Syn-McJ @pankcuf