Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(coinbase): migrate Buy endpoints from v2 to v3 #609

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 9, 2023

Issue being fixed or feature implemented

Coinbase is going to shut down some v2 API endpoints. We need to migrate, starting from the Buy feature

What was done?

  • Replace v2/accounts/{account_id}/buys with api/v3/brokerage/orders calls.
  • Rearrange Buy flow: no need to create and commit an order as the /orders endpoint executes the order immediately.
  • Improve HTTPClient errors.
  • Fix the de-authentication button.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf October 9, 2023 07:46
@Syn-McJ Syn-McJ self-assigned this Oct 9, 2023
@Syn-McJ Syn-McJ merged commit d57cbf3 into dashpay:develop Oct 10, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the chore/coinbase-buy-api branch October 10, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants