Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Integration Page #109

Closed
wants to merge 3 commits into from
Closed

Update Integration Page #109

wants to merge 3 commits into from

Conversation

salmad3
Copy link
Contributor

@salmad3 salmad3 commented Oct 21, 2021

General edits and tweaks - proposing the numbered list in the very beginning be made into sub-sections.
A few links were also edited as part of the SDK section to address the issue, but not exactly sure if that was all that was required. Feedback appreciated:)

Link to preview page: https://dash-docs--109.org.readthedocs.build/en/109/developers/integration.html

@thephez
Copy link
Collaborator

thephez commented Oct 21, 2021

Quick observation - something in this restructure has broken the sidebar. For example, the InstantSend, API Services, and SDK Resources categories no longer contain the topics they should. It may be due to now have sequential "Special Transactions" sections with different heading levels near to beginning of the page?

Compare vs the current site to see what I mean https://docs.dash.org/en/stable/developers/integration.html#

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like the split to subsections 👍 Just need to get the sidebar sorted out. Here are some comments on the other changes. A few are style related and we can discuss that minutiae offline 🙂

developers/integration.rst Outdated Show resolved Hide resolved
developers/integration.rst Outdated Show resolved Hide resolved
developers/integration.rst Outdated Show resolved Hide resolved
developers/integration.rst Outdated Show resolved Hide resolved
developers/integration.rst Outdated Show resolved Hide resolved
developers/integration.rst Outdated Show resolved Hide resolved
@thephez thephez requested a review from strophy October 21, 2021 14:30
@salmad3 salmad3 requested a review from thephez October 25, 2021 10:26
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the decoderawtransaction should not be included in the IS stuff as updated in this PR: #108. It may be easier to just remove in your branch than rebase on 0.17.0, but it's up to you.

@thephez
Copy link
Collaborator

thephez commented Nov 1, 2021

Closing in favor of #114 which pulled in these commits and makes additional changes.

@thephez thephez closed this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants