Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option to get from grovedb without using cache #222

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

QuantumExplorer
Copy link
Collaborator

Issue being fixed or feature implemented

There was a small issue inconsistency issue in rs-drive where we were not getting the same cost value for getting a contract, and I realized this was due to caching. Since we always need that value to be deterministic even outside of transactions it made sense to offer a way to get directly without cache.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit d06557b into develop Jan 5, 2023
@QuantumExplorer QuantumExplorer deleted the feat/directget branch January 5, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants