Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mixed tree level proofs #230

Merged
merged 18 commits into from
Jan 16, 2023
Merged

Conversation

iammadab
Copy link
Contributor

@iammadab iammadab commented Jan 16, 2023

Issue being fixed or feature implemented

Allow proofs to add elements from different tree levels to the result set.

What was done?

If an element encountered through a query, has no subquery value (default or conditional) and no subquery path (translation), it gets added to the result set.
We achieve this by reducing the limit offset values deterministically, across both proof generation and verification.

How Has This Been Tested?

Added unit tests.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@iammadab iammadab marked this pull request as ready for review January 16, 2023 18:37
@QuantumExplorer QuantumExplorer merged commit 6d9b63a into develop Jan 16, 2023
@QuantumExplorer QuantumExplorer deleted the feat/mixed-proof-results branch January 16, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants