feat: path query merging v2! #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: subquery paths (partial Sam's work) (#217) * start work on subquery paths * fixed proof generation * refactoring * refactoring * more temp work * feat: subquery paths proofs (#216) * start work on subquery paths * fixed proof generation * refactoring * refactoring * more temp work * potentially implementation of verify_subquery_path * fix build errors * modify proof construction + add test to check n > 1 valid translations * add more test for subquery path * clean up comments in proof generation * clean up verify comments * more comment clean up * fmt * fmt * fmt * fix node bindings * fix clippy warnings Co-authored-by: Quantum Explorer <quantum@dash.org> * better merge_default_subquery_branch Co-authored-by: Wisdom Ogwu <40731160+iammadab@users.noreply.github.com>
…db into feat/query-item-intersect4
* wip * add test for range item compare * add more compare tests * wip
…db into feat/query-item-intersect4
feat: patching estimated costs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Path query merging didn't allow for subqueries. Me and Wisdom couldn't let this stand!
What was done?
A lot, we introduced query item intersections, amount a lot of other improvements and fixes.
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only