fix: atomic writes #259
Merged
fix: atomic writes #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fominok
force-pushed
the
fix/atomic-writes
branch
from
f3a12b5
to
017795d
Compare
fominok
force-pushed
the
fix/atomic-writes
branch
from
017795d
to
c0a1b52
Compare
fominok
force-pushed
the
fix/atomic-writes
branch
from
8cf0a15
to
f778203
Compare
iammadab
approved these changes
Jun 22, 2023
QuantumExplorer
requested changes
Jun 22, 2023
storage/src/rocksdb_storage/storage_context/context_immediate.rs
Outdated
Show resolved
Hide resolved
storage/src/rocksdb_storage/storage_context/context_immediate.rs
Outdated
Show resolved
Hide resolved
QuantumExplorer
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This PR removes previously existing means to write straight ahead to storage from a subtree.
What was done?
StorageContextimplementations were removed and replaced with batched versions as they semantically meant immediate write access to the storage, which causes non-atomic behavior as almost all GroveDB modifications involve changes to multiple subtrees.CrashMerkand crash test as irrelevant to MerkHow Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only