-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: getIdentitiesContractKeys endpoint #1766
Merged
QuantumExplorer
merged 76 commits into
v1.0-dev
from
refactor/remove-get-identities-queries
Apr 27, 2024
Merged
feat!: getIdentitiesContractKeys endpoint #1766
QuantumExplorer
merged 76 commits into
v1.0-dev
from
refactor/remove-get-identities-queries
Apr 27, 2024
+19,908
−21,997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19f9d9e
to
08c8cf4
Compare
shumkov
requested changes
Mar 18, 2024
shumkov
previously approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
QuantumExplorer
requested changes
Mar 18, 2024
packages/rs-drive-abci/src/query/identity_based_queries/identities/mod.rs
Show resolved
Hide resolved
shumkov
previously approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Let's wait on the new methods needed before this one is merged in. |
QuantumExplorer
previously approved these changes
Apr 27, 2024
QuantumExplorer
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Remove
getIdentities
andgetIdentitiesByPublicKeyHashes
queries, and addgetIdentitiesContractKeys
as a replacementWhat was done?
getIdentitiesContractKeys
and e2e testHow Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only