Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: getIdentitiesContractKeys endpoint #1766

Merged
merged 76 commits into from
Apr 27, 2024
Merged

feat!: getIdentitiesContractKeys endpoint #1766

merged 76 commits into from
Apr 27, 2024
+19,908 −21,997

Conversation

markin-io
Copy link
Contributor

@markin-io markin-io commented Mar 12, 2024 •
edited

Issue being fixed or feature implemented

Remove getIdentities and getIdentitiesByPublicKeyHashes queries, and add getIdentitiesContractKeys as a replacement

What was done?

  • Remove queries from proto messages
  • Remove queries from drive
  • Update JS and Rust clients
  • Added getIdentitiesContractKeys and e2e test

How Has This Been Tested?

  • CI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io force-pushed the refactor/remove-get-identities-queries branch from 19f9d9e to 08c8cf4 Compare March 13, 2024 12:21
@markin-io markin-io changed the title refactor: remove multiple identities queries refactor!: remove multiple identities queries Mar 13, 2024
@markin-io markin-io added this to the v1.0.0 milestone Mar 13, 2024
@shumkov shumkov changed the title refactor!: remove multiple identities queries chore!: remove multiple identities queries Mar 13, 2024
shumkov
shumkov previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shumkov
shumkov previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuantumExplorer
Copy link
Contributor

Let's wait on the new methods needed before this one is merged in.

@shumkov shumkov self-requested a review March 19, 2024 13:34
@markin-io markin-io changed the title chore!: remove multiple identities queries feat!: getIdentitiesContractKeys endpoint Apr 24, 2024
@QuantumExplorer QuantumExplorer merged commit cfdc7dd into v1.0-dev Apr 27, 2024
77 checks passed
@QuantumExplorer QuantumExplorer deleted the refactor/remove-get-identities-queries branch April 27, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@shumkov shumkov Awaiting requested review from shumkov shumkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markin-io @QuantumExplorer @shumkov