Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename DataContractConfig.validate_config_update #1843

Merged
merged 1 commit into from
May 13, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented May 10, 2024

Issue being fixed or feature implemented

DataContract related structures has method validate_update to validate compartiblity as a part of Data Contract Update transition validation. For example, DocumentTypeRef.validate_update. There are more introduced in #1835. To keep consistent naming and remove repetition of meaning we need to rename DataContractConfig.validate_config_update

What was done?

  • Renamed DataContractConfig.validate_config_update to DataContractConfig.validate_update

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title refactor: rename DataContractConfig.validate_config_update for consistency refactor: rename DataContractConfig.validate_config_update May 10, 2024
@shumkov shumkov merged commit ed36e73 into v1.0-dev May 13, 2024
65 checks passed
@shumkov shumkov deleted the refactor/validate-config-rename branch May 13, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants