-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: data contract transition validation issues #1835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better testablity
QuantumExplorer
requested changes
May 10, 2024
...data_contract/document_type/class_methods/create_document_types_from_document_schemas/mod.rs
Show resolved
Hide resolved
...wasm-dpp/src/errors/consensus/basic/data_contract/incompatible_data_contract_schema_error.rs
Outdated
Show resolved
Hide resolved
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/mod.rs
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/data_contract_update/state/v0/mod.rs
shumkov
commented
May 13, 2024
.../validation/state_transition/state_transitions/data_contract_create/identity_nonce/v0/mod.rs
Outdated
Show resolved
Hide resolved
shumkov
changed the title
fix: misc data contract validation issues
fix!: data contract transition validation issues
May 13, 2024
QuantumExplorer
requested changes
May 13, 2024
.../validation/state_transition/state_transitions/data_contract_create/identity_nonce/v0/mod.rs
Outdated
Show resolved
Hide resolved
...execution/validation/state_transition/state_transitions/data_contract_create/state/v0/mod.rs
Show resolved
Hide resolved
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/mod.rs
Outdated
Show resolved
Hide resolved
...idation/state_transition/state_transitions/data_contract_create/advanced_structure/v0/mod.rs
Show resolved
Hide resolved
QuantumExplorer
previously approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
packages/rs-dpp/src/data_contract/document_type/methods/validate_update/v0/mod.rs
Outdated
Show resolved
Hide resolved
packages/rs-dpp/src/data_contract/document_type/methods/validate_update/v0/mod.rs
Outdated
Show resolved
Hide resolved
...execution/validation/state_transition/state_transitions/data_contract_create/state/v0/mod.rs
Show resolved
Hide resolved
QuantumExplorer
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Before production release we need to review and fix if necessary all critical paths in Platform. State transition validation and execution logic, specifically Data Contract Create and Update transitions are one of them.
What was done?
assert_matches
to simplify testingIndexLevel.validate_update
DocumentTypeRef
and perform complete update validation inDocumentTypeRef.validate_update
.DataContract.validate_update
CheckTxResult
is missing in case of asset lock based transition on check txHow Has This Been Tested?
Covered Data Contract Create and Update transitions validation with tests
Breaking Changes
Data Contract Create and Update transitions validation logic is changed so previously created block chain data might not be valid anymore.
Checklist:
For repository code-owners and collaborators only