Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dpp): decomposed integer types for document type properties #1968

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

Previously we only had an integer type in the property type for a data contract, now that has been decomposed.

What was done?

Switch integer to u128, i128, u64... u8, i8

How Has This Been Tested?

Breaking Changes

Should not be a breaking change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer
Copy link
Member Author

Just CI issues. Merging.

@QuantumExplorer QuantumExplorer merged commit 77f7a96 into v1.0-dev Jul 17, 2024
61 of 63 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/betterTypes branch July 17, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants