Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: publish envoy and dashmate-helper docker images after release #595

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

shuplenkov
Copy link
Collaborator

@shuplenkov shuplenkov commented Oct 24, 2022

Issue being fixed or feature implemented

New Envoy and Dashmate helper docker images must be published on release

What was done?

release.yml GitHub script was modified to release new Docker images

How Has This Been Tested?

Manual

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Oct 24, 2022
@@ -53,7 +53,7 @@ RUN apk update && \
apk add --no-cache docker-cli

LABEL maintainer="Dash Developers <dev@dash.org>"
LABEL description="DAPI Helper Node.JS"
LABEL description="Dashamte Helper Node.JS"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashmate

Copy link
Collaborator

@jawid-h jawid-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@shuplenkov shuplenkov merged commit 87b5c3c into v0.24-dev Oct 25, 2022
@shuplenkov shuplenkov deleted the release-envoy branch October 25, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants