Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): SSL domain verification config could not be generated in WSL #673

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

shuplenkov
Copy link
Collaborator

@shuplenkov shuplenkov commented Dec 15, 2022

Issue being fixed or feature implemented

Under WSL environment SSL domain verification envoy config messed up in one line.

What was done?

Fixed DOT engine configuration.

How Has This Been Tested?

Manual

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Dec 15, 2022
@shuplenkov shuplenkov changed the title fix(dashmate): envoy config for SSL domain verification could noy be generated under some environments fix(dashmate): SSL domain verification config could not be generated in WSL Dec 15, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov shuplenkov merged commit c2d89bc into v0.24-dev Dec 15, 2022
@shuplenkov shuplenkov deleted the fix-envoy branch December 15, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants