-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drive): merk caching in contract caching (irony) #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
changed the title
fix: fix for merk caching in contract caching (irony)
fix: merk caching in contract caching (irony)
Jan 6, 2023
shumkov
changed the title
fix: merk caching in contract caching (irony)
fix(drive): merk caching in contract caching (irony)
Jan 6, 2023
shumkov
previously approved these changes
Jan 6, 2023
shumkov
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Merk caching was causing a problem. The returned cost operation might use the cache, and this cache might cause the cost to be lower if we are using transactions and the item was just inserted. Because contracts would be added to the cache on insert this was the case. Fetching them from disk was less expensive. When the node would come back online and fetch it again the cost would differ between nodes causing a source of non determinism.
What was done?
In order to fix this we allow querying without the Merk cache. While this might not have been strictly needed, it was also a good improvement for many query methods when proofs are not needed.
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only