Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashmate): enable platform option #853

Merged
merged 5 commits into from
Mar 23, 2023
Merged

feat(dashmate): enable platform option #853

merged 5 commits into from
Mar 23, 2023

Conversation

shuplenkov
Copy link
Collaborator

@shuplenkov shuplenkov commented Mar 23, 2023 •
edited by shumkov
Loading

Issue being fixed or feature implemented

We don't want to start platform on the mainnet for now even having platform configuration for HPMN

What was done?

  • Provide an option to disable platform

How Has This Been Tested?

Manually

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Mar 23, 2023
shumkov
shumkov approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title dashmate: disable platform for HPMN on mainnet feat(dashmate): enable platform option Mar 23, 2023
@shuplenkov shuplenkov merged commit 24b95a6 into v0.24-dev Mar 23, 2023
@shuplenkov shuplenkov deleted the disable_platform_24 branch March 23, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov