Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashmate): hint to setup a node on start failure #866

Merged
merged 3 commits into from
Mar 29, 2023
Merged

feat(dashmate): hint to setup a node on start failure #866

merged 3 commits into from
Mar 29, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Mar 28, 2023

Issue being fixed or feature implemented

Sometimes people run dashmate start without knowing that the node configuration is required.

What was done?

  • Remove base config as default
  • Show a hint to run dashmate setup if default config is empty

How Has This Been Tested?

Manually

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.24.0 milestone Mar 28, 2023
@shumkov shumkov requested a review from antouhou as a code owner March 28, 2023 14:14
@shumkov @strophy
Update packages/dashmate/src/oclif/command/ConfigBaseCommand.js
4585db5 
Co-authored-by: strophy <32928115+strophy@users.noreply.github.com>
strophy
strophy previously approved these changes Mar 28, 2023
View reviewed changes
@shumkov shumkov merged commit 52b7448 into v0.24-dev Mar 29, 2023
@shumkov shumkov deleted the dashmate-help-start branch March 29, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strophy strophy strophy approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shumkov @strophy