Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible overflow issues #877

Merged
merged 6 commits into from
Apr 4, 2023
Merged

fix: possible overflow issues #877

merged 6 commits into from
Apr 4, 2023

Conversation

qrayven
Copy link
Contributor

@qrayven qrayven commented Mar 31, 2023

Issue being fixed or feature implemented

What was done?

The PR fixes potential overflow panics for artithmetic operations

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@qrayven qrayven marked this pull request as ready for review March 31, 2023 10:39
@shumkov shumkov changed the title Fix overflow issues fix: possible overflow issues Apr 4, 2023
shumkov
shumkov previously approved these changes Apr 4, 2023
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# Conflicts:
#	packages/rs-dpp/src/identity/state_transition/identity_update_transition/validate_identity_update_transition_state.rs
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 32ddec7 into v0.24-dev Apr 4, 2023
@shumkov shumkov deleted the fix/overflows branch April 4, 2023 14:12
markin-io pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@markin-io markin-io mentioned this pull request Apr 26, 2023
5 tasks
markin-io pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants