Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress in Listr for slow tasks #96

Closed
strophy opened this issue Dec 15, 2020 · 5 comments
Closed

Show progress in Listr for slow tasks #96

strophy opened this issue Dec 15, 2020 · 5 comments
Labels
dashmate Dashmate related

Comments

@strophy
Copy link
Collaborator

strophy commented Dec 15, 2020

Listr can appear to hang when doing a slow operation like downloading images for the first time. We should show this progress.

Expected Behavior

Progress bar should be included in Listr output

Current Behavior

Listr appears to hang

Possible Solution

Redirect stream from docker-compose to Listr task.output?

Alternatives Considered

Additional Context

@antouhou
Copy link
Collaborator

Oh yeah, that would be great. Just thought about it yesterday - mn-bootstrap works very slowly in Travis and no build passes at the moment, so that would help a lot with that

@strophy
Copy link
Collaborator Author

strophy commented Jan 15, 2021

I got really stuck here trying to understand streams and promises, so I'm not sure if this approach is correct. Output currently looks like this:

strophy@X250:~/Code/docker-dashd$ mn setup
mn-bootstrap 0.18.0-dev.1

✔ Set configuration preset
  › Selected testnet as default config
✔ Set node type
  › Selected fullnode type
✔ Configure external IP address
  › 71.198.220.130 is set
✔ Initialize Tenderdash
✔ Update config 
strophy@X250:~/Code/docker-dashd$ mn start
✔ Start testnet full node
  ✔ Check node is not started
  ✔ Start services 
Creating network "dash_masternode_testnet_default" with the default driver
Creating volume "dash_masternode_testnet_core_data" with default driver
Creating volume "dash_masternode_testnet_drive_abci_data" with default driver
Creating volume "dash_masternode_testnet_drive_mongodb_data" with default driver
Pulling dapi_tx_filter_stream (dashpay/dapi:0.17)...
0.17: Pulling from dashpay/dapi
Digest: sha256:4a4de51e33d44b028adeecd34629eb07d01874c3bedc304ef0efdd761f68eac2
Status: Downloaded newer image for dashpay/dapi:0.17
Creating dash_masternode_testnet_drive_mongodb_1 ... done
Creating dash_masternode_testnet_core_1          ... done
Creating dash_masternode_testnet_sentinel_1      ... done
Creating dash_masternode_testnet_drive_abci_1    ... done
Creating dash_masternode_testnet_dapi_insight_1     ... done
Creating dash_masternode_testnet_drive_tenderdash_1      ... done
Creating dash_masternode_testnet_dapi_tx_filter_stream_1 ... done
Creating dash_masternode_testnet_dapi_api_1              ... done
Creating dash_masternode_testnet_dapi_envoy_1            ... done
Creating dash_masternode_testnet_dapi_nginx_1            ... done
strophy@X250:~/Code/docker-dashd$

I wonder if we could at least match the indentation of the task displaying the output somehow? And maybe filter to only show some of the output (e.g. lines starting with "Pulling")?

@dashameter
Copy link
Contributor

Can we also show an error if a docker container keeps restarting ? (Drive likes to do that, then you just see a stuck Task without a title but you don't know if it just tasks long or if something has gone bad in the background)

@shumkov shumkov transferred this issue from dashevo/dashmate Dec 15, 2021
@shumkov shumkov added the dashmate Dashmate related label Dec 15, 2021
@dash-maverick
Copy link

closed because obsolete at this point (dashmate is operating differently at this point)

@dash-maverick
Copy link

It turned out to be still valid, sorry for my mistake. It's just a nice-to-have. It can remain as an open issue, it's a nice easy one for a community contribution as well.

@dash-maverick dash-maverick reopened this Apr 5, 2022
@pshenmic pshenmic added this to the v0.24.0 milestone Mar 15, 2023
@shumkov shumkov modified the milestones: v0.24.0, v0.25.0 May 10, 2023
@shumkov shumkov closed this as completed Sep 26, 2024
@shumkov shumkov removed this from the v0.25.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashmate Dashmate related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants