Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashmate): interface binding configuration #1220

Merged
merged 12 commits into from Jul 10, 2023
Merged

feat(dashmate): interface binding configuration #1220

merged 12 commits into from Jul 10, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 7, 2023 •
edited

Issue being fixed or feature implemented

A user has a need to specify a network interface to bind dashmate service ports

What was done?

  • Added docker.network.bindIp config option
  • Fixed invalid config path detection on set
  • Ignored protobufjs vulerability 1092393
  • Moved ignored NPM vulnerabilities to yarn config from CI workflow
  • Fixed NPM audit exit code with updating Yarn to 3.6.1
  • Commit DAPI-GRPC Rust files

How Has This Been Tested?

With CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from antouhou as a code owner July 7, 2023 13:03
@shumkov shumkov added this to the v0.25.0 milestone Jul 7, 2023
jawid-h
jawid-h previously approved these changes Jul 7, 2023
View reviewed changes
@shumkov shumkov merged commit 7bcf6f5 into master Jul 10, 2023
26 checks passed
@shumkov shumkov deleted the feat/dashmate/bind_ip branch July 10, 2023 14:25
shumkov added a commit that referenced this pull request Jul 10, 2023
@shumkov
feat(dashmate): interface binding configuration (#1220)
a5281c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawid-h jawid-h jawid-h approved these changes

@antouhou antouhou Awaiting requested review from antouhou antouhou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shumkov @jawid-h