test(dashmate): successful migration test #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshenmic
requested review from
shumkov,
antouhou and
QuantumExplorer
as code owners
shumkov
changed the title
shumkov
requested changes
Oct 23, 2023
packages/dashmate/test/unit/commands/config/configFile/migrateConfigFileFactory.js
Outdated
Show resolved
Hide resolved
packages/dashmate/test/unit/commands/config/configFile/mock_config.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Add a test that will run the migration config code and check if final config is valid, executable and contains right image versions
What was done?
How Has This Been Tested?
Locally
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only