Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rs-sdk): introduce Mockable trait to simplify handling of streaming #1565

Merged
merged 12 commits into from
Nov 6, 2023
Merged

refactor(rs-sdk): introduce Mockable trait to simplify handling of streaming #1565

merged 12 commits into from
Nov 6, 2023

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Nov 6, 2023

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review November 6, 2023 18:07
QuantumExplorer
QuantumExplorer approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow Lukazs, that's really good work.

@QuantumExplorer QuantumExplorer merged commit c74ef9a into feat/register Nov 6, 2023
0 of 2 checks passed
@QuantumExplorer QuantumExplorer deleted the rs-sdk/refactor-mocking-mockable branch November 6, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@shumkov shumkov Awaiting requested review from shumkov

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lklimek @QuantumExplorer