-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rs-sdk cache of data contracts #1568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I am going to merge this in, I do not believe that the SDK should hold cached contracts, as that is the responsibility of the wallet.
Basically the SDK should not be stateful.
use crate::Sdk; | ||
|
||
/// State transition identifier | ||
pub struct TxId([u8; 32]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to just say TxId is a Bytes32, and get all the benefit from that already defined struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also should be in DPP and not the SDK
Issue being fixed or feature implemented
What was done?
Changes summary:
TODO:
Refactor Documents to use ContextProvider to retrieve data contract
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only