feat(platform)!: document serialization across versions #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
requested changes
Nov 23, 2023
packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs
Show resolved
Hide resolved
shumkov
requested changes
Nov 23, 2023
...document/documents_batch_transition/document_transition/document_create_transition/v0/mod.rs
Outdated
Show resolved
Hide resolved
…m:dashpay/platform into feat/documentSerializationAccrossVersions
…m:dashpay/platform into feat/documentSerializationAccrossVersions
…m:dashpay/platform into feat/documentSerializationAccrossVersions
shumkov
requested changes
Nov 23, 2023
QuantumExplorer
changed the title
QuantumExplorer
changed the title
…m:dashpay/platform into feat/documentSerializationAccrossVersions
QuantumExplorer
deleted the
feat/documentSerializationAccrossVersions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
If one would update a data contract by adding fields, the document serialization and deserialization would break.
What was done?
We added a position for each property in a document.
Deserialization now will work with and pair of document_type/version. For example if you deserialize a document serialized with version 1 with the document type of the contract version 3 the additional new fields will just be None.
How Has This Been Tested?
Wrote a few tests to verify this all worked.
Breaking Changes
Checklist:
For repository code-owners and collaborators only