feat!: rs-sdk is thread safe and doesn't require &mut #1620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
rs-sdk
should not require mutable references, as it complicates usage of the Sdk.For example,it might require locking.
What was done?
We use Arc and lock inside Sdk whenever required.
Also some smaller refactorings implemented, for example:
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only