refactor(drive): change error messages to String #1839
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
shumkov
changed the title
shumkov
reviewed
May 13, 2024
| @@ -199,7 +199,7 @@ impl Drive { | |||
| platform_version, | |||
| )? | |||
| .ok_or(Error::Query(QuerySyntaxError::DataContractNotFound( | |||
| "contract not found", | |||
| "contract not found".to_string(), | |||
There was a problem hiding this comment.
You can use https://docs.rs/thiserror-ext/latest/thiserror_ext/derive.Construct.html so you can pass both Strings and &str to constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Change all the error messages in rs-drive from str to String
What was done?
Change all the error messages in rs-drive from str to String
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only