feat(dpp): add withdraw purpose for IdentityPublicKey
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawid-h
changed the title
withdraw purpose for IdentityPublicKey
5 tasks
thephez
reviewed
Aug 24, 2022
| @@ -240,6 +240,7 @@ IdentityPublicKey.PURPOSES = { | |||
| AUTHENTICATION: 0, | |||
| ENCRYPTION: 1, | |||
| DECRYPTION: 2, | |||
| WITHDRAW: 3, | |||
There was a problem hiding this comment.
The implementation here doesn't align with the Identity DIP: https://github.com/dashpay/dips/blob/master/dip-0011.md#identity-public-key which uses purpose 3 for something else and doesn't include withdraw. That difference will need to be reconciled with the DIP at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Need to implement withdrawal purpose for identity pub key
What was done?
Added new Purpose - withdraw
How Has This Been Tested?
With tests
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only