Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rs-drive-abci): config file is broken #892

Merged
merged 4 commits into from
Apr 7, 2023

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Apr 6, 2023

Issue being fixed or feature implemented

Envy doesn't handle correctly int values inside flattened structs. See softprops/envy#26

What was done?

  1. Use string values in config structs and implement getters
  2. Fixed small issue with Docker image

How Has This Been Tested?

  • Unit test passes
  • Started drive-abci in Docker

Breaking Changes

none

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek requested review from QuantumExplorer and removed request for shumkov and antouhou April 6, 2023 20:52
@lklimek lklimek merged commit 0d51294 into feat/abci_validation Apr 7, 2023
@lklimek lklimek deleted the fix/config-broken branch April 7, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants