Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new vote extenison type THRESHOLD_RAW #715

Merged
merged 57 commits into from
Jan 31, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Dec 12, 2023

Issue being fixed or feature implemented

Threshold-recovered vote extensions are converted into a canonical form, containing things like round and height.
Unfortunately, for Dash Platform withdrawal transactions, threshold extension signatures must be constructed using exact content of the exension, not canonical form.

What was done?

  1. Added new type of vote extension, THRESHOLD_RAW, that is signed without any canonization. It also allows providing sign_request_id to be used.
  2. Refactored vote extensions to a cleaner, more object-oriented architecture.
  3. Refactored SignItem to use the same field names as in Dash Core QuorumSign endpoint.
  4. Updated documentation.

How Has This Been Tested?

Github Actions

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jan 16, 2024
@github-actions github-actions bot closed this Jan 21, 2024
@lklimek lklimek reopened this Jan 29, 2024
@lklimek lklimek changed the base branch from v0.14-dev to v0.13-dev January 29, 2024 08:20
@lklimek lklimek changed the base branch from v0.13-dev to v0.14-dev January 29, 2024 08:20
@github-actions github-actions bot removed the Stale label Jan 30, 2024
shumkov
shumkov previously approved these changes Jan 30, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@lklimek lklimek requested a review from shumkov January 31, 2024 09:50
@lklimek lklimek enabled auto-merge (squash) January 31, 2024 09:54
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit f10efa0 into v0.14-dev Jan 31, 2024
18 of 19 checks passed
@shumkov shumkov deleted the feat/vote-extension-sign-id branch January 31, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants