Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race condition when adding new channel to NodeInfo #735

Merged
merged 4 commits into from
Feb 9, 2024
Merged

fix: race condition when adding new channel to NodeInfo #735

merged 4 commits into from
Feb 9, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Feb 7, 2024 •
edited

Issue being fixed or feature implemented

Race condition was detected in https://github.com/dashpay/tenderdash/actions/runs/7797474816/job/21322879727?pr=726

What was done?

Implemented thread-safe slice for list of channels

How Has This Been Tested?

GH Actions

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review February 8, 2024 15:39
@lklimek lklimek enabled auto-merge (squash) February 8, 2024 15:41
shumkov
shumkov approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit fce9e90 into v0.14-dev Feb 9, 2024
15 of 16 checks passed
@shumkov shumkov deleted the fix/mempool-race branch February 9, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

@shotonoff shotonoff Awaiting requested review from shotonoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lklimek @shumkov