feat(abciclient): support timeouts in abci calls #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Some transactions, like CheckTx, should time out if not processed within some reasonable time period.
This helps avoid system overload.
What was done?
In ABCI Socket Client, added a context which is checked before sending message. If message was waiting too long in a queue and context expired, error is returned.
CheckTX in gRPC (*BroadcastTx) and p2p was limited to 1 second.
How Has This Been Tested?
GHA + testing on devnet.
Breaking Changes
Some GRPC and P2P requests can return context canceled error.
Checklist:
For repository code-owners and collaborators only