Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): channel enqueue timeout and improved router cleanup #754

Merged
merged 19 commits into from
Mar 12, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 8, 2024

Issue being fixed or feature implemented

Channels are blocking when number of queued items is too big. We need a way to reject further messages sent to these channels.

What was done?

  1. Introduced enqueue timeout
  2. Refactored router to better handle cleanups.
  3. Added config option [mempool] tx-enqueue-timeout

How Has This Been Tested?

On ouzo devnet + added unit test

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title Feat/enqueue timeout feat(p2p): channel enqueue timeout Mar 8, 2024
@lklimek lklimek changed the title feat(p2p): channel enqueue timeout feat(p2p): channel enqueue timeout and improved router cleanup Mar 8, 2024
@lklimek lklimek marked this pull request as ready for review March 8, 2024 16:26
@lklimek lklimek enabled auto-merge (squash) March 8, 2024 16:46
shumkov
shumkov previously approved these changes Mar 12, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 5764ab3 into v0.14-dev Mar 12, 2024
15 checks passed
@lklimek lklimek deleted the feat/enqueue-timeout branch March 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants